Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow in formatNumber on some platforms #1669

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Fix integer overflow in formatNumber on some platforms #1669

merged 1 commit into from
Feb 8, 2019

Conversation

evgenykochetkov
Copy link
Contributor

No description provided.

@evgenykochetkov evgenykochetkov self-assigned this Feb 8, 2019
knopki
knopki approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@knopki knopki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov force-pushed the fix-stdlib-int-overflow-in-format-number branch from ef82449 to 36987a1 Compare February 8, 2019 10:11
brusherru
brusherru approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@evgenykochetkov evgenykochetkov force-pushed the fix-stdlib-int-overflow-in-format-number branch from 36987a1 to cad589d Compare February 8, 2019 11:41
@evgenykochetkov evgenykochetkov merged commit 6b57300 into master Feb 8, 2019
@evgenykochetkov evgenykochetkov deleted the fix-stdlib-int-overflow-in-format-number branch February 8, 2019 12:03
@evgenykochetkov evgenykochetkov mentioned this pull request Feb 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knopki knopki knopki approved these changes

@brusherru brusherru brusherru approved these changes

@nkrkv nkrkv Awaiting requested review from nkrkv

Assignees

@evgenykochetkov evgenykochetkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @knopki @brusherru