Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta- and generated nodes descriptions #1685

Merged
merged 4 commits into from
Feb 14, 2019

Conversation

nkrkv
Copy link
Member

@nkrkv nkrkv commented Feb 13, 2019

Closes #1647, #1427

Also, generates descriptions for custom type terminals.

From now on, all built-in type terminals must be listed in built-in-patches.xodball. Otherwise, a build-time error will occur.

null,
2
);
// Verify the build-in-patches.json provides all terminals, they might be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/xod-project/built-in-patches.xodball Outdated Show resolved Hide resolved
"path": "@/input-byte"
},
"@/input-dead": {
"description": "This terminal should not be visible to an end-user.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@nkrkv nkrkv force-pushed the doc-1427-patch-nodes-descriptions branch from 5208aae to 03cbfeb Compare February 14, 2019 09:06
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nkrkv nkrkv merged commit a20e16a into master Feb 14, 2019
@nkrkv nkrkv deleted the doc-1427-patch-nodes-descriptions branch February 14, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants