Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding a bus node while linking in the right position #1716

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Fix adding a bus node while linking in the right position #1716

merged 1 commit into from
Mar 11, 2019

Conversation

brusherru
Copy link
Contributor

There is no issue. Reported by @gabbapeople in the chat

To reproduce:

  • Start linking
  • Press "B" to place a bus node

Expected to see a new bus node at the mouse position.
Actually, it placed somewhere outside the view area.

@brusherru brusherru self-assigned this Mar 11, 2019
nkrkv
nkrkv approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evgenykochetkov
evgenykochetkov approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please merge it into 0.28.x

@brusherru brusherru changed the base branch from master to 0.28.x March 11, 2019 12:49
@brusherru brusherru merged commit b807be9 into 0.28.x Mar 11, 2019
@brusherru brusherru deleted the fix-add-bus-node-position branch March 11, 2019 21:01
@evgenykochetkov evgenykochetkov mentioned this pull request Mar 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

@knopki knopki Awaiting requested review from knopki

@gabbapeople gabbapeople Awaiting requested review from gabbapeople

Assignees

@brusherru brusherru

Labels
regression s:client t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov