Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load project with invalid patch paths #2099

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

brusherru
Copy link
Contributor

It fixes #2097

packages/xod-fs/src/messages.js Outdated Show resolved Hide resolved
packages/xod-fs/src/messages.js Outdated Show resolved Hide resolved
packages/xod-fs/src/messages.js Outdated Show resolved Hide resolved
@brusherru brusherru force-pushed the fix-2097-do-not-load-invalid-patch-paths branch from 2154b28 to 2c30112 Compare February 16, 2021 12:23
@brusherru brusherru requested a review from nkrkv February 16, 2021 12:24
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

See one more typo below though

packages/xod-fs/src/messages.js Outdated Show resolved Hide resolved
@brusherru brusherru force-pushed the fix-2097-do-not-load-invalid-patch-paths branch from 2c30112 to 681f3f9 Compare February 17, 2021 13:09
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brusherru brusherru merged commit 1bb00e0 into master Feb 24, 2021
@brusherru brusherru deleted the fix-2097-do-not-load-invalid-patch-paths branch February 24, 2021 14:56
@brusherru brusherru mentioned this pull request Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XOD IDE loads libraries with invalid patch paths
3 participants