Introduce variadic-pass nodes #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykochetkov
force-pushed
the
feat-1144-variadic-pass
branch
from
5bf511e
to
22a813a
Compare
evgenykochetkov
force-pushed
the
feat-1144-variadic-pass
branch
from
22a813a
to
b17f125
Compare
brusherru
reviewed
Mar 9, 2021
| } from './patchPathUtils'; | ||
| import { createAdditionalValueTerminalGroups } from './expandVariadicNodes'; | ||
|
|
||
| const expandPassPatch = R.curry((desiredArityLevel, patch) => { |
There was a problem hiding this comment.
It would be nice to provide a signature for the function
| // expand all patches(starting from a specified entry patch) | ||
| // | ||
|
|
||
| const traverseExpandableQueue = ( |
There was a problem hiding this comment.
Shouldn't it be in a xod-func-tools? 🤔
| // expand all patches(starting from a specified entry patch) | ||
| // | ||
|
|
||
| const traverseExpandableQueue = ( |
There was a problem hiding this comment.
Also, a signature and some comments would be nice.
brusherru
approved these changes
Mar 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1144