feat: stop performing transactional writes on single, unchanged items #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergaultney
changed the title
jwsloan
reviewed
Jul 22, 2021
jwsloan
reviewed
Jul 22, 2021
| @@ -133,7 +136,12 @@ def boto3_transact_multiple_but_optimize_single(TransactItems: List[dict], **kwa | |||
| if set(command) == {"Delete"}: | |||
| ddb_client.delete_item(**{**item_args, **kwargs}) | |||
| return | |||
| # we don't (yet) support single writee optimization for things other than Put or Delete | |||
| if set(command) == {"ConditionCheck"}: | |||
There was a problem hiding this comment.
How would we end up with a solitary ConditionCheck?
There was a problem hiding this comment.
a put_item where the value is identical to what's currently in the items fetched.
jwsloan
approved these changes
Jul 22, 2021
|
@jwsloan thanks for the feedback. I've changed the comments and logs to try to make some of this a little more self-explanatory. |
petergaultney
commented
Jul 22, 2021
| @@ -71,14 +71,17 @@ def _write( | |||
| ) | |||
|
|
|||
| hashable_item_key = hashable_key(item_key) | |||
| if hashable_item_key in items and items[hashable_item_key] == item_or_none: | |||
| """You've asked us to write an effect that would have no effect, and we are dropping it""" | |||
There was a problem hiding this comment.
an ideal language would allow these sorts of docstrings to automatically be logs. In fact, all logs would be docstrings - there would be no function or object to use for logging - the system would simply be aware of an active logger and pass these bare strings into the logger for processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22