Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken? #12

Closed
Efreak opened this issue Jan 25, 2017 · 25 comments
Closed

Broken? #12

Efreak opened this issue Jan 25, 2017 · 25 comments

Comments

@Efreak
Copy link

Efreak commented Jan 25, 2017

The generated credentials are brand new. I can log in thru the browser using them just fine (I'm unable to test them in other software such as 4pr0n/ripme due to changes in DA's website (see 4pr0n/ripme#425); I'm not sure if perhaps this issue is caused by the same changes?

[efreak:~/source/deviantart-gallery-downloader] master 17s 1 ± ruby fetch.rb -n http://starkiteckt.deviantart.com/gallery/
Using netrc's credential
Connecting to deviantART
Logging in
undefined method `username=' for nil:NilClass
will retry after 1 second
undefined method `username=' for nil:NilClass
will retry after 1 second
undefined method `username=' for nil:NilClass
will retry after 1 second
undefined method `username=' for nil:NilClass
login failed after 3 retries
You might not be able to fetch the age restricted resources
Connecting to gallery
/home/efreak/source/deviantart-gallery-downloader/lib/deviantart_gallery_downloader.rb:24:in `fetch': undefined method `[]' for nil:NilClass (NoMethodError)
        from fetch.rb:3:in `<main>'
@xofred
Copy link
Owner

xofred commented Feb 7, 2017

Fixed, plz pull the newest master branch and try again...

@nonamethanks
Copy link

nonamethanks commented Feb 7, 2017

Hello, I cloned the latest master and it still returns the same error.

Using netrc's credential
Connecting to deviantART
Logging in
Log on successful
Connecting to gallery
/home/nonamethanks/tools/deviantart-gallery-downloader/lib/deviantart_gallery_downloader.rb:23:in `fetch': undefined method `[]' for nil:NilClass (NoMethodError)
	from fetch.rb:3:in `<main>'

@xofred
Copy link
Owner

xofred commented Feb 10, 2017

If possible, may you provide the gallery link? Maybe pagination selector is not suited for every gallery...

@nonamethanks
Copy link

http://oevrlord.deviantart.com/
http://martinhanford1974.deviantart.com/
Really no gallery I've tried works.

@xofred
Copy link
Owner

xofred commented Feb 13, 2017

I've tried http://oevrlord.deviantart.com/gallery/, it works. Remember to use GALLERY's PAGE, not author's page...

@xofred
Copy link
Owner

xofred commented Feb 15, 2017

@nonamethanks Is it ok now? If everything is find, I would like to close this issue.

@nonamethanks
Copy link

Yes, if I use the /gallery/ url it works @xofred

@xofred
Copy link
Owner

xofred commented Feb 15, 2017

Glad to hear it!

@xofred xofred closed this as completed Feb 15, 2017
@vxbinaca
Copy link
Contributor

vxbinaca commented Mar 9, 2017

Requesting re-open.

I purged the install of this script, still not working.
Purged my Gems install, still not working.

ruby fetch.rb -n http://alexandrab24.deviantart.com/gallery/?catpath=/

Using netrc's credential
Logging in
Log on successful
Connecting to gallery
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
failed to connect to gallery after 3 retries, abort

@xofred
Copy link
Owner

xofred commented Mar 10, 2017

Please try ruby fetch.rb -n http://alexandrab24.deviantart.com/gallery/ instead @vxbinaca

@xofred xofred reopened this Mar 10, 2017
@vxbinaca
Copy link
Contributor

Same result.

@xofred
Copy link
Owner

xofred commented Mar 14, 2017

2017-03-14 3 16 29
It has to be gallery's page such as http://alexandrab24.deviantart.com/gallery/, not http://alexandrab24.deviantart.com/ or anything else. @vxbinaca

@vxbinaca
Copy link
Contributor

I ran the same command you did and got the same error.

@xofred
Copy link
Owner

xofred commented Mar 16, 2017

@vxbinaca Could you provide the detailed error message, such as error line of code?

@vxbinaca
Copy link
Contributor

vxbinaca commented Apr 8, 2017

@xofred ptrace? That's the output I got:

ruby fetch.rb -n "http://megasweet.deviantart.com/gallery/"

Logging in
Log on successful
Connecting to gallery
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
will retry after 1 second
undefined method `[]' for nil:NilClass
failed to connect to gallery after 3 retries, abort

@xofred
Copy link
Owner

xofred commented Apr 20, 2017

@vxbinaca Plz check out dev branch, it may solve the issue. And it can provide more error messages if not.

@1n5aN1aC
Copy link

I was having the same issue on my debian system, and the dev branch fixed it.

@1n5aN1aC
Copy link

1n5aN1aC commented Jun 16, 2017

EDIT: It's only fetching the first page (usually around 22 or so) then it thinks it's done. With or without the "/?catpath=/"

Tested on 4 different user's galleries, same results.

@xofred
Copy link
Owner

xofred commented Jun 16, 2017

Without it. If it still not work, Could you provide the gallery link for me to debug? @1n5aN1aC

@1n5aN1aC
Copy link

Well, something like ruby fetch.rb USERNAME PASSWORD http://sangrde.deviantart.com/gallery/ begins to download, but starts at 1/22, and once it reaches 22/22, it just says "all downloads completed."

I've tried it on 3 other artists' galleries as well, and all of them I've tried so far, either with personal credential, or with -n seem to do the same thing.

@xofred
Copy link
Owner

xofred commented Jun 19, 2017

Turns out to be an account setting issue. Please go to https://www.deviantart.com/settings/browsing. In "General Browsing" section, make sure "Display" as "24 Thumbnails per Page" and "Paging" as "Click through pages"
2017-06-19 11 36 58

@1n5aN1aC
Copy link

Ahh, so "scroll through pages" isn't compatible. Makes sense, even if it is disappointing.

I'd suggest you add that tidbit to a FAQ somewhere, but it's solved for me!

@xofred
Copy link
Owner

xofred commented Jun 20, 2017

Good point, README updated.

@xofred xofred closed this as completed Jun 20, 2017
@vxbinaca
Copy link
Contributor

Requesting a re-open this has cropped back up, or the open issue might possibly be a fix. Why he diff'd instead of a PR is beyond me.

@1n5aN1aC
Copy link

Sadly, can confirm. As of maybe a little over a week ago, even the dev branch is broken again.
Will provide output text / more information in a couple hours, assuming I don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants