Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should @typescript-eslint/parser be listed in peer dependencies? #60

Closed
aladdin-add opened this issue Jul 12, 2022 · 1 comment · Fixed by #61
Closed

should @typescript-eslint/parser be listed in peer dependencies? #60

aladdin-add opened this issue Jul 12, 2022 · 1 comment · Fixed by #61

Comments

@aladdin-add
Copy link
Contributor

aladdin-add commented Jul 12, 2022

a while ago, the xo style guide has been added to @eslint/create-config. In the PR we tried to switch to use the package eslint-config-xo-typescript when users choose typescript + xo.

the problem is: @typescript-eslint/parser was not listed in its peer dependencies. Surely, it's not an issue for npm v7+ users - it's listed in @typescript-eslint/eslint-plugin's peerdeps and will be auto installed. But it won't work for yarn/pnpm/... users.

related discussion: eslint/create-config#33

@sindresorhus
Copy link
Member

sindresorhus commented Jul 17, 2022

I feel that's an issue Yarn and PNPM need to resolve.

But if anyone feels strongly and cares enough to contribute a fix, I will merge it.

aladdin-add added a commit to aladdin-add/eslint-config-xo-typescript that referenced this issue Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants