Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out .gitignore patterns before globbing #235

Closed
sindresorhus opened this issue Jun 23, 2017 · 9 comments
Closed

Filter out .gitignore patterns before globbing #235

sindresorhus opened this issue Jun 23, 2017 · 9 comments
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Member

sindresorhus commented Jun 23, 2017 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

See: #204 (comment)

Doing it after globbing results in a large performance regression when running on large projects, like in #234.

IssueHunt Summary

pvdlg pvdlg has been rewarded.

Backers (Total: $80.00)

Submitted pull Requests

Tips
@sindresorhus
Copy link
Member Author

On a really large project it's very inefficient. See: #234 (comment)

@sindresorhus sindresorhus mentioned this issue Oct 18, 2017
Closed
marionebl added a commit to marionebl/globby that referenced this issue Oct 18, 2017
@marionebl
Add gitignore option
72b6f19 
* First introduced in sindresorhus/xo
* Known to be a performance bottleneck xojs/xo#235
* Motivation: xojs/xo#236
@marionebl marionebl mentioned this issue Oct 18, 2017
Merged
marionebl added a commit to marionebl/globby that referenced this issue Oct 18, 2017
@marionebl
Add gitignore option
424d87d 
* First introduced in sindresorhus/xo
* Known to be a performance bottleneck xojs/xo#235
* Motivation: xojs/xo#236
@sindresorhus
Copy link
Member Author

The .gitignore handling moved to https://github.com/sindresorhus/globby, so it needs to be fixed there.

@IssueHuntBot
Copy link

@issuehuntfest has funded $80.00 to this issue. See it on IssueHunt

@janat08 janat08 mentioned this issue May 1, 2019
Closed
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@janat08 janat08 mentioned this issue Jun 15, 2019
Closed
@fisker
Copy link
Contributor

fisker commented Aug 7, 2021

I think this is already fixed, should close.

@sindresorhus
Copy link
Member Author

@fisker Do you know which commit fixed it?

@fisker
Copy link
Contributor

fisker commented Aug 8, 2021

Maybe I fixed it? The old one only ignore DEFAULT_IGNORES, and I removed it, see this.

But I read the ignores config, and use it in another PR https://github.com/xojs/xo/pull/584/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R154

@fisker
Copy link
Contributor

fisker commented Aug 8, 2021

Wait... No, this is the line glob files https://github.com/xojs/xo/pull/583/files#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346L164, I don't know.

@fisker
Copy link
Contributor

fisker commented Aug 8, 2021

Most likely this PR #436

@issuehunt-oss
Copy link

issuehunt-oss bot commented Aug 8, 2021

@sindresorhus has rewarded $72.00 to @pvdlg. See it on IssueHunt

  • 💰 Total deposit: $80.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $8.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gitignore patterns before globbing and 97 janat08/globby
3 participants
@sindresorhus @fisker @IssueHuntBot