Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please do not import unittest #53

Closed
tomasz-sternumiot opened this issue May 26, 2021 · 1 comment
Closed

Please do not import unittest #53

tomasz-sternumiot opened this issue May 26, 2021 · 1 comment

Comments

@tomasz-sternumiot
Copy link

Great project!

Could you please do not import unittest framework in the library code?

python-humanfriendly/humanfriendly/compat.py

Line 68 in 1abbe85

import unittest

Thank you!
xolox added a commit that referenced this issue Sep 17, 2021
@xolox
Remove humanfriendly.compat.unittest (#53)
278215d
@xolox
Copy link
Owner

xolox commented Sep 17, 2021

This is fixed in version 10.0 that was just released.

@xolox xolox closed this as completed Sep 17, 2021
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 27, 2021
@kraj
python3-humanfriendly: upgrade 9.2 -> 10.0
f6b3e55 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `openembedded#53`_).

**Internal changes:**

- Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 27, 2021
@kraj
python3-humanfriendly: upgrade 9.2 -> 10.0
3d9a4bf 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `openembedded#53`_).

**Internal changes:**

- Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 27, 2021
@kraj
python3-humanfriendly: upgrade 9.2 -> 10.0
d1e1637 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `openembedded#53`_).

**Internal changes:**

- Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 28, 2021
@kraj
python3-humanfriendly: upgrade 9.2 -> 10.0
b6b69ed 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `openembedded#53`_).

**Internal changes:**

- Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Sep 28, 2021
@kraj
python3-humanfriendly: upgrade 9.2 -> 10.0
69ceac5 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `openembedded#53`_).

**Internal changes:**

- Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead pushed a commit to openembedded/meta-openembedded that referenced this issue Sep 28, 2021
@kraj
python3-humanfriendly: upgrade 9.2 -> 10.0
a49f8f7 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `#53`_).

**Internal changes:**

- Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@kraj
src/meta-openembedded:python3-humanfriendly: upgrade 9.2 -> 10.0
26dde6e 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `#53`_).

**Internal changes:**

- Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@kraj
src/meta-openembedded:python3-humanfriendly: upgrade 9.2 -> 10.0
064ee8b 
`Release 10.0`_ (2021-09-17)
----------------------------
**Noteworthy changes:**

- Merged pull request `#45`_ to resolve the issue caused by the conditional
  :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+.

- Updated the readme to use Python 3 in the example (reported in issue `#56`_).
  Also added a mention of the ``humanfriendly --demo`` command.

- Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is
  using at this point; it had been rendered useless quite a long time ago
  (requested in issue `#53`_).

**Internal changes:**

- Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project
  from Travis CI to GitHub Actions and from Coveralls.io to Codecov.

- Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx
  documentation errors.

.. _Release 10.0: xolox/python-humanfriendly@9.2...10.0
.. _#45: xolox/python-humanfriendly#45
.. _#53: xolox/python-humanfriendly#53
.. _#54: xolox/python-humanfriendly#54
.. _#56: xolox/python-humanfriendly#56

Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xolox @tomasz-sternumiot