Allow correct behavior of 'parse_size' and 'format_size' #8

merged 2 commits into from Sep 29, 2016


None yet

3 participants


Maintain default behavior (for semantic versioning), but provide an option for people who want file sizes handled in base 10 instead of base 2. Would require a minor version bump.

standage added some commits Jun 30, 2016
@standage standage Implemented correct handling of prefixes based on IEEE 1540 6812bf1
@standage standage Added unit tests
coveralls commented Jun 30, 2016 edited

Coverage Status

Coverage increased (+0.03%) to 96.329% when pulling a54b07a on standage:master into 1021cac on xolox:master.

@xolox xolox added a commit that referenced this pull request Sep 29, 2016
@xolox Proper support for IEEE 1541 definitions of units?
Refer to issue 4 and pull requests 8 and 9 on GitHub for details:
 - #4
 - #8
 - #9
@xolox xolox merged commit a54b07a into xolox:master Sep 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage increased (+0.03%) to 96.329%
xolox commented Sep 29, 2016

Hi Daniel and thanks for this pull request! I merged your changes but then decided to iterate further, switch the default to powers of ten and make improvements to the parsing code. More details available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment