-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Cannot read property 'start' of undefined #27
Comments
The source code where the problem raise is :
|
Hi, I just updated RTD, could you try again please with the latest? If you have errors, please enable |
Removed, reinstalled, debug true and run grunt --debug
Chrome 27.0 (Mac): Executed 11 of 11 SUCCESS (0.078 secs / 0.01 secs) Running "bgShell:synchronizeMirrorApp" (bgShell) task Running "bgShell:instrumentCode" (bgShell) task Running "bgShell:runTests" (bgShell) task
Finished in 5.994 seconds Running "postLatestUnitCoverage" task Running "bgShell:killReports" (bgShell) task Running "bgShell:runCoverageCheck" (bgShell) task
and a few second later, i have also :
|
Do you have an idea how to debug step by step, or log some values ? |
To debug, go to the /test/rtd/rtd.conf.js file and enable debug It looks like istanbul is having some problems. You could try going into the core.js file under Another thing to try, can you try deleting the node_modules directory and then Another thing, try to clone this repo and see if it works out the box: https://github.com/xolvio/real-time-development-with-meteor |
if you |
FYI, I removed bgShell:runCoverageCheck in Gruntfile.js -> no error after the run i have a coverage.txt file but in build/reports/coverage/Chrome 27.0 (Mac) folder =============================== Coverage summary =============================== Statements : 100% ( 21/21 ) Branches : 100% ( 6/6 ) Functions : 100% ( 8/8 ) Lines : 100% ( 21/21 ) ================================================================================ |
What you have there is the coverage check but only from the unit test runs, it has not been combined with the coverage from the running meteor app (both client and server). That's what the runCoverageCheck does, it goes to see the combined results. It looks like somehow, the npm dependency that Istanbul needs is not the right version and that would explain why node_modules/istanbul/lib/object-utils would be not working. Perhaps this has something to do with npm itself. What version of NPM are you using there? I'm using: |
upgrade to the same versions -> same errors npm WARN package.json growl@1.7.0 No repository field. => Meteor 0.6.4 is available. Update this project with 'meteor update'.
|
Using
Are we running the same version of meteorite?
From root of the example app repo
It doesn't seem to matter if the meteor servers being started are 0.6.3.1 or 0.6.4. |
to suppress the warning of npm, add the following to node_modules/growl/package.json before "main" : "repository": { "type": "git", "url": "git://github.com/visionmedia/node-growl.git" }, |
i solved the phantomjs problem (installing 1.9.0 instead of 1.9.1-1) but i have the same error message with PhantomJS and Chrome :
|
@wenzowski @lc3t35 I'm a little confused on what errors we're talking about now! Where in the chain are you stuck? |
Updated comment -> i found that the problem was in Gruntfile.js , replace /coverage/client by /coverage in this task ! grunt.registerTask('postLatestUnitCoverage', 'postLatestUnitCoverage', function () { var done = this.async(); postJson('localhost', 8000, '/coverage', getLatestCoverageObject(), done); }); |
@lc3t35 Not quite! That means the coverage object is being posed to /coverage, which doesn't accept posts. Since the problem is in the /coverage/client code, it looks like it's fixed it, but you won't get combined coverage this way. Next thing to do, can you zip/tar up your whole directory as is and send it to me? |
yes -> i send tar at sam address ? coverage is not 100% with this wrong fix but it's no more crashing the RTD :) |
Can you put it on some file share? dropbox? googledrive? |
uploading in Dropbox ... Done : https://www.dropbox.com/s/9ch9xww35fzvl0t/rtd.tar |
thanks On Thu, Jul 4, 2013 at 1:39 PM, Laurent Roger notifications@github.comwrote:
Sam Hatoum | Founder | www.xolvio.com | +1 (415) 857 1317 |
@xolvio would you mind sharing your globally installed versions of
so I can confirm I have the same ones in my path? @lc3t35 This is still the bundled istanbul middleware issue right? Npm warnings in trace don't seem like an issue to me. Did you notice a change in this issue installing/removing growl? |
Hmm...in the example app this issue still presents for me, even with phantom 1.9.0. Copying |
versions are
About just copying the conf file.. can you try that a few times to see if it's deterministic or intermittent? Sounds very odd! |
Can confirm same global versions. Can confirm copying config is deterministic on my macbook. I'll try on coworkers' rigs Monday. |
Can someone else please try this solution that @wenzowski suggested: "Copying test/rtd/karma.conf.js to test/karma.conf.js without modifying it in any way solves the problem for me in the example app" @wenzowski are you saying you used to get this |
@wenzowski yes this is the istanbul issue, i've checked all the version are the same. @xolvio tryed the copy, same error |
@lc3t35 I tried your tar'd code from dropbox and it worked straight away for me. This tells me whatever it is, it's likely to be outside of the actual project. I've just updated RTD to fix the npm version in packages.json for RTD. Could you |
I don't think it's the actual coverage object, because anytime you hit the The problem I think is the /coverage/client post is not working due to a On Fri, Jul 5, 2013 at 12:13 AM, Laurent Roger notifications@github.comwrote:
|
retrying a fresh reinstall (rm -rf real-time-development-with-meteor) |
oh wait, I haven't bumped the version there. One sec.... On Fri, Jul 5, 2013 at 12:23 AM, Laurent Roger notifications@github.comwrote:
|
ready |
@xolvio yes, it's a global configuration problem of OSX10.8.4 -> can you send me the npm ls output so i can check if it's the same. |
also try npm ls output:
|
i still have the warnings : |
Hum ! istanbul@0.1.40 , karma@0.8.6 in the global scope |
aha! I have istanbul@0.1.39 On Fri, Jul 5, 2013 at 12:51 AM, Laurent Roger notifications@github.comwrote:
|
using specific npm installation with version : npm i -g karma@0.8.5 phantomjs@1.9.0-0 selenium-webdriver grunt-cli jasmine-node istanbul@0.1.39 evrything is working fine, no error, 100% coverage :) Thank you |
Excellent, thank you very much for your help. I'm updating the instructions to fix those versions |
Did fresh install a few times (rm -rf real-...) var getInstrumentedCodeString = function (excludesArray) { |
oops! thanks for the build thing! Did you remove your existing global istanbul package first? What does |
After doing a complete environment reset
Everything works as expected. I'd say that perhaps |
I've managed to repeat this locally. So it seems the problem is in the unit test coverage reports being posted to the mirror app that is causing the problem. If you go to localhost:8000/coverage before the unit tests are posted, it works. This means the middleware is ok. Moreover, if I try to post coverage reports from a last-known-good-version to the mirror app, that also works. It's only when posting new unit coverage reports, which also leads me to think it's something to do with karma.. but what?! Grrrr this one is annoying me! |
I tried using: Unit tests and acceptance tests runs but stalls on coverage tests I can confirm the issue with accessing localhost:8000/coverage. [stou$ real-time-development-with-meteor]$ curl -D headers.txt localhost:8000/coverage [stou$ real-time-development-with-meteor]$ By the way I am running Mac OS X 10.7.5, but does not seem to make much difference |
Finally gets the example to run properly in Ubuntu Linux 12.04-2. Need to set the DISPLAY in system environment. To use chrome. Must install google-chrome, not chromium. |
Thanks for reporting back |
MacOS 10.8.3, Node 0.8.14, meteor 0.6.4
Error raised during coverage tests
The text was updated successfully, but these errors were encountered: