Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefinitionList Extension does not allow custom attributes on description elements #59

Closed
aKzenT opened this issue Sep 19, 2016 · 3 comments
Labels

Comments

@aKzenT
Copy link
Contributor

aKzenT commented Sep 19, 2016

For our project, I'm writing an extension which sets custom attributes on some Markdown Elements, which should be rendered in the resulting HTML (e.g. for styling).

This works fine for almost all elements (paragraphs, lists, etc.), but fails for the definition list extension, because it will always write an empty

element without honoring any attributes set on the description paragraph.

There is also currently no good workarround for this issue. I would currently need to copy the complete extension only to change this single part.

Best regards,
Thomas

@xoofx
Copy link
Owner

xoofx commented Sep 19, 2016

Hm weird, the code here and there does write the attributes. Could you elaborate how do you add these attributes?

@aKzenT
Copy link
Contributor Author

aKzenT commented Sep 19, 2016

It't the
renderer.Write("<dd>");
that's causing the problem for me.

@xoofx
Copy link
Owner

xoofx commented Sep 19, 2016

Ah good catch, you can make a PR if you want to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants