Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Type.GetTypeHandle in RendererBase #633

Closed
wants to merge 1 commit into from

Conversation

MihaZupan
Copy link
Collaborator

From #632 (comment)

GetType:

Method Mean Error StdDev
RenderWithoutToString 73.27 us 0.071 us 0.362 us

Type.GetTypeHandle

Method Mean Error StdDev
RenderWithoutToString 62.20 us 0.112 us 0.547 us

@xoofx
Copy link
Owner

xoofx commented Apr 23, 2022

Oops, need to close this one, sorry pushed the commit 210b39e almost at the same time! 😅

Thank you for the optimization on Type.GetTypeHandle, that still a nice boost on this part! 😉

@coveralls
Copy link

coveralls commented Apr 23, 2022

Pull Request Test Coverage Report for Build 2212571021

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.176%

Totals Coverage Status
Change from base Build 2212248592: 0.0%
Covered Lines: 25744
Relevant Lines: 27001

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants