This repository has been archived by the owner on Feb 10, 2022. It is now read-only.
Detect and ignore invalid IFD offsets #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to add a |
rubenv
force-pushed
the
invalid-ifd-offset
branch
from
8377706
to
e3101c2
Compare
|
Looks good, only it break on go < 1.7 due to missing io.SeekStart see https://travis-ci.org/xor-gate/goexif2/jobs/329060365#L474. You may also change the |
|
@xor-gate Already pushed a fix for the missing constant. Will adjust the error messages. |
Some files have IFD offset pointers that point outside of the image file. This can be detected and ignored. Fixes xor-gate#12
rubenv
force-pushed
the
invalid-ifd-offset
branch
from
921e898
to
0805aec
Compare
|
@xor-gate All done! |
rubenv
force-pushed
the
invalid-ifd-offset
branch
from
0805aec
to
cf0ec88
Compare
|
Awesome, thanks! |
xor-gate
added a commit
that referenced
this pull request
Jan 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files have IFD offset pointers that point outside of the image
file. This can be detected and ignored.
Fixes #12