Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: make qwen_vl support streaming output #1425

Merged
merged 4 commits into from
May 8, 2024
Merged

ENH: make qwen_vl support streaming output #1425

merged 4 commits into from
May 8, 2024

Conversation

Minamiyama
Copy link
Contributor

No description provided.

@XprobeBot XprobeBot added the enhancement New feature or request label May 5, 2024
@XprobeBot XprobeBot added this to the v0.11.0 milestone May 5, 2024
@qinxuye qinxuye requested a review from codingl2k1 May 6, 2024 03:13
@codingl2k1
Copy link
Contributor

Could you add some unit tests? We don't run them in our CI because of resource limitations, but we can use them to check the code during development. https://github.com/xorbitsai/inference/blob/main/xinference/model/llm/tests/test_multimodal.py#L24

@Minamiyama
Copy link
Contributor Author

Minamiyama commented May 6, 2024 •
edited
Loading

Could you add some unit tests? We don't run them in our CI because of resource limitations, but we can use them to check the code during development. https://github.com/xorbitsai/inference/blob/main/xinference/model/llm/tests/test_multimodal.py#L24

how about this⬇️ record video？

QQ202456-182132.mp4

@codingl2k1
Copy link
Contributor

Cool!

qinxuye
qinxuye approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, excellent work.

@qinxuye qinxuye merged commit f9629e3 into xorbitsai:main May 8, 2024
8 of 12 checks passed
@qinxuye qinxuye mentioned this pull request May 8, 2024
Closed
@sunhaha123 sunhaha123 mentioned this pull request May 8, 2024
Merged
1 task
@liaotingyao liaotingyao mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinxuye qinxuye qinxuye approved these changes

@codingl2k1 codingl2k1 Awaiting requested review from codingl2k1

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Minamiyama @codingl2k1 @qinxuye @XprobeBot