Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Modify required reviews #665

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

aresnow1
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.5.2 milestone Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #665 (8052618) into main (4855622) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   93.55%   93.64%   +0.08%     
==========================================
  Files        1025     1025              
  Lines       79726    79726              
  Branches    16535    16535              
==========================================
+ Hits        74586    74656      +70     
+ Misses       3458     3393      -65     
+ Partials     1682     1677       -5     
Flag Coverage Δ
unittests 93.53% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 34f7bca into xorbitsai:main Aug 22, 2023
31 of 32 checks passed
@aresnow1 aresnow1 deleted the chore/mergify branch August 22, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants