Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Support copy_to semantic, from buffer to buffer #23

Merged
merged 17 commits into from
Jun 25, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented May 25, 2023

  1. Support copy_to, from list of buffers to list of buffers. Means that when xo.copy_to is invoked, the data has already been transferred to the destination buffer.
  2. Ucx copy_to

Tested for TPCH SF100 and SF1000.

Ref: xorbitsai/mars#77

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label May 25, 2023
@XprobeBot XprobeBot added this to the v0.0.6 milestone May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #23 (bf228b1) into main (56b832b) will increase coverage by 5.18%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   88.42%   93.60%   +5.18%     
==========================================
  Files          42       42              
  Lines        3187     3332     +145     
  Branches      638      668      +30     
==========================================
+ Hits         2818     3119     +301     
+ Misses        286      141     -145     
+ Partials       83       72      -11     
Flag Coverage Δ
unittests 93.45% <97.36%> (+5.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/router.py 95.53% <96.15%> (+1.86%) ⬆️
python/xoscar/backends/context.py 93.93% <96.66%> (+6.90%) ⬆️
python/xoscar/backends/communication/ucx.py 92.72% <96.96%> (+26.33%) ⬆️
python/xoscar/backends/core.py 96.33% <100.00%> (+2.92%) ⬆️
python/xoscar/backends/indigen/pool.py 92.77% <100.00%> (+8.33%) ⬆️
python/xoscar/backends/pool.py 95.91% <100.00%> (+5.48%) ⬆️
python/xoscar/backends/test/pool.py 98.46% <100.00%> (ø)

... and 2 files with indirect coverage changes

@qianduoduo0904 qianduoduo0904 changed the title ENH: Support copy_to semantic, from buffer to buffer FEAT: Support copy_to semantic, from buffer to buffer May 26, 2023
@XprobeBot XprobeBot added feature and removed enhancement New feature or request labels May 26, 2023
@ChengjieLi28 ChengjieLi28 marked this pull request as ready for review June 5, 2023 10:45
python/xoscar/context.pyx Outdated Show resolved Hide resolved
python/xoscar/backends/router.py Show resolved Hide resolved
python/xoscar/backends/context.py Outdated Show resolved Hide resolved
python/xoscar/backends/context.py Outdated Show resolved Hide resolved
python/xoscar/backends/pool.py Show resolved Hide resolved
@mergify mergify bot merged commit 5dd2fa7 into xorbitsai:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants