Enable create_actor_pool to use elastic ip #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostyplanet
changed the title
frostyplanet
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 88.97% 85.03% -3.95%
==========================================
Files 48 54 +6
Lines 4038 4552 +514
Branches 770 831 +61
==========================================
+ Hits 3593 3871 +278
- Misses 358 587 +229
- Partials 87 94 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
frostyplanet
force-pushed
the
fix_0.0.0.0
branch
7 times, most recently
from
9589a8b
to
8eaf728
Compare
frostyplanet
force-pushed
the
fix_0.0.0.0
branch
3 times, most recently
from
8d378d2
to
66d7012
Compare
Because ipv6 ip has multiple ':'
Introduced from commit 5ffa0ea Author: Adam Ning <frostyplanet@gmail.com> Date: Wed Jul 10 15:24:08 2024 +0800 ENH: fix non-local client connection problem when server listen on 0.0.0.0 (xorbitsai#92)
frostyplanet
force-pushed
the
fix_0.0.0.0
branch
from
4b2ae34
to
112fd2e
Compare
frostyplanet
force-pushed
the
fix_0.0.0.0
branch
2 times, most recently
from
c5fc35b
to
c5aae48
Compare
Usage:
create_actor_pool(elastic_address,
n_process=0,
extra_conf={'listen_elastic_ip': True},
)
While xinference worker serve on cloud elastic_ip,
the address used in create_actor_pool() and create_actor both have to be the elastic ip,
in order for ActorRef passing around RPC method to client, but we could only listen on 0.0.0.0.
(Because the ip is not only valid outside the host)
frostyplanet
force-pushed
the
fix_0.0.0.0
branch
from
c5aae48
to
0a5cdf8
Compare
2 tasks
luweizheng
added a commit
to luweizheng/xoscar
that referenced
this pull request
Sep 24, 2024
Co-authored-by: Lu Weizheng <luweizheng36@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_actor_pool: Add extra_conf option listen_elastic_ip
Usage:
While xinference worker serve on cloud elastic_ip,
the address used in create_actor_pool() and create_actor both have to be the elastic ip,
in order for ActorRef passing around RPC method to client, but we could only listen on 0.0.0.0.
(Because the ip is not only valid outside the host)
Additional fixes:
ucx://127:0.0.1:3456:in the ip partAdd cross unittests for ipv6 X listen_elastic_ip X ucx.
The only missing part is ucx X ipv6, because ucx does not supoort ipv6
ISSUE: #96