Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulse time max value #141

Closed
xoseperez opened this issue May 22, 2017 · 5 comments
Closed

Pulse time max value #141

xoseperez opened this issue May 22, 2017 · 5 comments

Comments

@xoseperez
Copy link
Owner

Originally reported by: treowayne (Bitbucket: treowayne, GitHub: Unknown)


I have a bunch of Epurna'd Sonoff switches. On some of them I use the pulse time feature as a timer to automatically power down the attached device. A couple of devices are set to "pulse" for 3600 seconds (an hour), and that seems to work fine. I set up another one to pulse for 14400 seconds (four hours) and it stayed on overnight.

I am guessing the pulse time probably has a max value determined by the max value of a data type. It would be great if this maximum was larger (best case) or at least if the web interface would inform (or enforce) a maximum value.

Great work though Xose!

@xoseperez
Copy link
Owner Author

The pulse feature uses the Ticker library that (aparently) stores time internally in a 32bit variable representing microseconds, that gives you a max time span of around 71 minutes, so that might be the reason for the behaviour you describe. Honestly the pulse functionality was originally meant for short pulses (opening a garage door, triggering a door bell,...).

@xoseperez
Copy link
Owner Author

Limit the max pulse value in web interface

@xoseperez
Copy link
Owner Author

Removing milestone: 1.8.2 (automated comment)

@xoseperez
Copy link
Owner Author

Fixed with 1.8.2

@xoseperez
Copy link
Owner Author

Original comment by Stavros Korokithakis (Bitbucket: Stavros, GitHub: Stavros):


Is there any way to change the max value to around 60 minutes, at least? The current max of 60s is very restrictive, as I have a Sonoff that controls the light in a room I'm always only in for ~5 minutes, so I'd like it to turn off after 10m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant