-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change relay pulse time while active #816
Comments
I have changed the way the Ticker works. TBH I'm not 100% sure it's a good idea (more processing load) but it works and does what you want. Also, I have added a Staged for release. |
… on the go (xoseperez#816)" This reverts commit aaab65f.
Maybe keep the ticker? And supercede this by #831 for timed on / off state. I did entertain the idea of detaching the ticker completely if either mode or time changes and, like this approach, reattach ticker starting from current time. It does exactly what issue says, but makes relay logic slightly tangled :/ Timed on / off will keep the logic that pulse only changes when state does, and is with added benefit of dynamic pulse timer. |
… on the go (xoseperez#816)" This reverts commit aaab65f.
Changing pulse time from Web does not reset currently running timer i.e. using Normally off / 60s:
Turn on -> Change time to 10s -> ... wait 60 seconds... -> relay turns off
It works afterwards ofc:
Turn on -> ... wait 10 seconds ... -> relay turns off
Also, because _relayConfigure is only called by websockets code, there is no way to set
relayTimeN
using terminal commands besides rebooting device.The text was updated successfully, but these errors were encountered: