Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dialog.react.js #350

Closed
wants to merge 2 commits into from
Closed

Update Dialog.react.js #350

wants to merge 2 commits into from

Conversation

ritesh-malav
Copy link
Contributor

This change will remove the ripple effect from the dialog. I believe the material design 2.0 that has been released recently does not say anything about the ripple effect on the dialog component. I have already asked for this change but it was not done earlier. And this will take care of the input from the dialog.

This change will remove the ripple effect from the dialog. I believe the material design 2.0 that has been released recently does not say anything about the ripple effect on the dialog component. I have already asked for this change but it was not done earlier.
@xotahal
Copy link
Owner

xotahal commented May 14, 2018

Why TouchableWithoutFeedback is a good choise for onPress feedback? I agree we could provide option to select feedback. Ripple feedback will be always default. But this is not a way how to do it.

It should have been done in general for all components.

Here is the last pull request - #279 (comment)

And here is briefly idea:

Let's use <Feedback> instead of <RippleFeedback> in components

And write Feedback component like this:

render() {
    const { type, ...rest } = this.props;

    if (!onPress) {
        return rest.children
    }

    if (type === 'Ripple') {
        <RippleFeedback {...rest}>{children}</RippleFeedback>
    } else if (type === 'WithoutFeedback') {
        <TouchableWithoutFeedback {...rest}>{children}<....>
    } ....
}

@xotahal xotahal closed this May 14, 2018
@ritesh-malav
Copy link
Contributor Author

Or how about we create a ripple Prop in component that can be passed from the root component level.

@ritesh-malav
Copy link
Contributor Author

Or one another suggestion could be to implement it like card component. Where if(onPress) then provide else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants