allow to merge cells #13
Conversation
|
Awesome! |
AlexKovalevych
force-pushed
the
merge-cells
branch
from
1b59217
to
a257c9c
Compare
|
@xou Sure, added |
| # If you need to merge cells, send a list of tuples, | ||
| # where each tuple is a pair of start and end cell. | ||
| # For example to merge cells from A1 to C1 use: | ||
| # sheet = %Sheet{rows: rows, merge_cells: [{"A1", "C1"}]} |
There was a problem hiding this comment.
Is it possible to integrate this into the actual executable code? (I typically run the libreoffice_test script in test/ to see if all the features appear to be working, I know this isn't optimal :/ but it would be great if that would show the expected result).
Does this work with vertical cells as well (or a combination of horizontal and vertical?) If so, would be great to include this in the example (one single "block" of merged cells should be OK), if not it would be great if you could add a quick note somewhere pointing out the limitations).
There was a problem hiding this comment.
Yes, it works in both ways, i'll add a code
| @@ -200,6 +200,18 @@ defmodule Elixlsx.XMLTemplates do | |||
| List.foldr("", &<>/2) | |||
| end | |||
|
|
|||
| defp xl_merge_cells([]) do | |||
| "" | |||
| end | |||
There was a problem hiding this comment.
minor nitpick: newline here please :)
AlexKovalevych
force-pushed
the
merge-cells
branch
from
a257c9c
to
ff94045
Compare
|
All done |
|
Great, thank you very much! I will push out a new release probably on the weekend. |
|
Sure, thanks! |
#11