Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic connect implementation #427

Merged
merged 25 commits into from
Mar 18, 2023
Merged

basic connect implementation #427

merged 25 commits into from
Mar 18, 2023

Conversation

xou816
Copy link
Owner

@xou816 xou816 commented Jan 13, 2022

image

@xou816 xou816 force-pushed the Ella-0-basic-connect-implementation branch 2 times, most recently from f9af36c to f8995ca Compare February 2, 2022 20:57
@mufeedali
Copy link

Does this MR also mean that spot will now be controllable from other devices like spotifyd is?

@xou816
Copy link
Owner Author

xou816 commented Feb 5, 2022

Nope, sorry!

@xou816 xou816 force-pushed the Ella-0-basic-connect-implementation branch from 8baf92f to d042bef Compare February 7, 2022 23:02
@xou816
Copy link
Owner Author

xou816 commented Feb 7, 2022 •
edited
Loading

its quite a nightmare to get this right...
right now the web connect api does not expose the queue so things like shuffle dont work well
also not handling the case where the playback source changes completely on the connected device, say switch to another playlist. not motivated to tackle this just yet

Does this MR also mean that spot will now be controllable from other devices like spotifyd is?

to elaborate on this: this is a very different thing, and a whole other can of worms too! I need to finish this one first, which is control other devices from Spot; controlling Spot from other devices is less interesting anyway and I'd recommend just using spotifyd/librespot if a gui is not needed anyway

@xou816 xou816 force-pushed the Ella-0-basic-connect-implementation branch 2 times, most recently from da208a7 to b51ef3a Compare March 13, 2022 17:38
@3nprob 3nprob mentioned this pull request Jun 20, 2022
Open
@xou816 xou816 mentioned this pull request Feb 18, 2023
Open
@xou816 xou816 force-pushed the Ella-0-basic-connect-implementation branch 2 times, most recently from c0a8077 to f3fba49 Compare February 28, 2023 21:42
@xou816 xou816 force-pushed the Ella-0-basic-connect-implementation branch from aa366c0 to 27b34b7 Compare March 18, 2023 23:08
@xou816
Copy link
Owner Author

xou816 commented Mar 18, 2023

its not perfect, def not... but lets go ahead with this and see how it goes. we'll improve on it over time

@xou816 xou816 marked this pull request as ready for review March 18, 2023 23:27
@xou816 xou816 force-pushed the Ella-0-basic-connect-implementation branch from 7122bef to 969956a Compare March 18, 2023 23:33
@xou816 xou816 merged commit 722b31a into development Mar 18, 2023
@xou816 xou816 mentioned this pull request Mar 18, 2023
Closed
3 tasks
@xou816 xou816 deleted the Ella-0-basic-connect-implementation branch March 19, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xou816 @mufeedali @Ella-0