Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezones #5

Merged
merged 13 commits into from
Oct 24, 2021
Merged

Timezones #5

merged 13 commits into from
Oct 24, 2021

Conversation

thekid
Copy link
Member

@thekid thekid commented Apr 1, 2018

Implements feature request #4

$calendar= (new ICalendar())->read($input);

$start= $calendar->date($calendar->events()->first()->dtstart()));  // a util.Date instance

Class renaming does not work like in PHP 7, cannot shadow classes from
the same namespace in 5.X
@thekid
Copy link
Member Author

thekid commented Apr 1, 2018

Now that text.ical.Date instances are used often in conjunction with util.Dates, it's probably wise to rename the first to IDate to avoid import conflicts. Can this be done in a BC-break-free manner?

@thekid thekid merged commit 54628e1 into master Oct 24, 2021
@thekid thekid deleted the feature/timezones branch October 24, 2021 15:32
thekid added a commit that referenced this pull request Oct 24, 2021
Fixes issue #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant