Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit code blocks as <code> wrapped in <pre> #17

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

thekid
Copy link
Member

@thekid thekid commented Mar 23, 2023

See #16. As far as I see from here https://github.com/commonmark/commonmark-spec/blob/8dbbe341608cf37d7fe9c3157c15e09cbbe359ce/alternative-html-blocks.txt#L165, https://spec.commonmark.org/0.30/#code-spans and https://spec.commonmark.org/0.30/#fenced-code-block this would also what the spec would expect.

⚠️: This is a BC break and would result in a major release, 7.0.0 at the time of writing.

@thekid
Copy link
Member Author

thekid commented Mar 23, 2023

As far as I see from [...] this would also what the spec would expect.

Yes, #14 verifies this shoud be <pre><code>...</code></pre>.

@thekid thekid merged commit 28f116a into master Mar 23, 2023
@thekid thekid deleted the refactor/wrap-code-blocks branch March 23, 2023 19:12
@thekid thekid mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant