Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cookie-based sessions #10

Closed
wants to merge 11 commits into from
Closed

Conversation

thekid
Copy link
Member

@thekid thekid commented May 15, 2022

This pull request adds a cookie-based session implementation to this library. Cookie-based sessions require no serverside storage and thus scale very well.

Usage

Inside the routing setup:

use web\session\CookieBased;
use web\auth\SessionBased;
use util\Secret;

$secret= new Secret('y+lCLaMzxlnHjkTt3FoPVQ_x5XTHSr78'); // 32 bytes!
$sessions= new CookieBased($secret);

$auth= new SessionBased($flow, $sessions);
return $auth->required(function($req, $res) {
  // Use $req->value('user')
});

A binary-safe 32 byte secret key can be generated using the following:

$ xp -d 'base64_encode(random_bytes(24))'
string(32) "ai4BO6rpwgezJztTalg5rt29XNJwMRMQ"

Security

As stated here:

[The] security risk of putting the session data in the session cookie is the danger of "session replay" attacks. If a valid session cookie is captured from a user's browser (it's visible in the browser's developer console) then that cookie can be copied to another machine and used in a rogue session at any time.

Though the same applies for server-side sessions with session IDs transmitted via cookies, we can destroy the attached session on the server-side to invalidate in these cases, e.g. by deleting the session file or removing the relevant row from the database. For cookie-based sessions, there is no way to remotely guarantee session destruction - and thus no way for a safe user-based "Log me off on all devices" functionality.

However, if we use cookie-based sessions to store short-lived access tokens, we can reduce this risk significantly: A replay can only occur during that window of time. For Microsoft 365, this time is roughly one hour.

👉 Long story short: If there's an easy possibility to use server-side sessions, do that. If dependencies come at a high cost and you have ways of managing the risk, or for development purposes, this implementation can be a valid choice.

Internals

The session data is encrypted in the cookie and then encoded in base64 to use 7 bit only. The first byte controls the algorithm used:

The encrypted value is signed by a hash to detect any bit flipping attacks.

Compression

To prevent hitting the browser cookie limits too early, the cookie values are compressed using LZW (which is relatively easy to implement and gives good savings without requiring an extra PHP extension compiled in) if it's deemed worthwhile. If the cookie value is compressed, the indicators above appear in lowercase (s and o instead of S and O).

An example:

  • JSON value (response from https://api.twitter.com/1.1/account/verify_credentials.json): 2814 bytes
  • Encrypted and encoded cookie value: 3807 bytes (pretty close to the limit!)
  • If compressed, decreases to 2477 bytes (more than a kilobyte saved, 65% of the size)

See also

https://github.com/SaintFlipper/EncryptedSession
https://blog.miguelgrinberg.com/post/how-secure-is-the-flask-user-session

@thekid thekid added the enhancement New feature or request label May 15, 2022
@thekid
Copy link
Member Author

thekid commented May 30, 2022

On second thought: I believe this should be in a separate library. This way, users will have to explicitely choose to use cookie-based sessions and are more likely to read the security implications they have.

@thekid thekid added the question Further information is requested label May 30, 2022
@thekid
Copy link
Member Author

thekid commented May 30, 2022

On second thought: I believe this should be in a separate library. This way, users will have to explicitely choose to use cookie-based sessions and are more likely to read the security implications they have.

https://github.com/xp-forge/cookie-sessions

@thekid thekid closed this May 30, 2022
thekid added a commit that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant