This repository has been archived by the owner on Nov 19, 2023. It is now read-only.
Refactor annotation handling #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Create a TestGroup class and two implementations. They reflect the groups in which tests are run, typically a class (but now extensible!) . Create a TestTarget class which is a slim wrapper around a TestCase instance and its before and after methods . Greatly simplify code inside run() and runTest() as well as addTest() and addTestClass()
|
Code is nicer, but memory usage is also up: Before: Timm@slate ~/devel/xp/core [seven]
$ unittest src/test/config/unittest/core.ini
# ...
✓: 2085/2115 run (30 skipped), 2085 succeeded, 0 failed
Memory used: 9637.11 kB (10428.49 kB peak)
Time taken: 1.273 secondsAfter: Timm@slate ~/devel/xp/core [seven]
$ unittest src/test/config/unittest/core.ini
# ...
✓: 2085/2115 run (30 skipped), 2085 succeeded, 0 failed
Memory used: 16506.51 kB (17400.98 kB peak)
Time taken: 1.290 seconds |
|
After this commit: using PHP 5.5 iterators: Timm@slate ~/devel/xp/core [seven]
$ unittest src/test/config/unittest/core.ini
# ...
✓: 2085/2115 run (30 skipped), 2085 succeeded, 0 failed
Memory used: 15354.34 kB (16214.02 kB peak)
Time taken: 1.275 seconds |
|
Cannot solve the memory issues, this is worth rewriting from scratch, but may serve as inspiration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.