Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-- should close named arg. lists #13

Closed
1 of 2 tasks
xparq opened this issue Jan 26, 2023 · 0 comments
Closed
1 of 2 tasks

-- should close named arg. lists #13

xparq opened this issue Jan 26, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@xparq
Copy link
Owner

xparq commented Jan 26, 2023 •
edited
Loading

There's no way currently to have -1 or "--++##XXX#++--" etc. as positional args, or allow things like /c or //file/... both as an option and a path. (However, that // for long opts. really shouldn't be supported at all... Add a (negative) test for that!)

  • But, since ~1.9 there's at least a RejectUnknown flag, the only thing left is uncomment (and implement) it. ;)
  • So, seeing -- could perhaps just turn that flag on, and call it a day! :-o (Which would be awkward for consistency, in case someone would like to check the flags after parsing. It's not the a very appealing attitude to use config data arbitrarily as mutable state. :) )
    • And it's also wrong! Even with known args, where RejectUnknown has no effect, there should be a way to disable them (to get filenames like --known).
  • Also, then -- -- should obviously result in a positional arg. called --. (Test it, as it's probably easy to f* up!)
@xparq xparq changed the title -- should close name parameter lists -- should close named parameter lists Jan 26, 2023
@xparq xparq added the enhancement New feature or request label Jan 30, 2023
@xparq xparq mentioned this issue Nov 2, 2023
Closed
@xparq xparq pinned this issue Nov 2, 2023
@xparq xparq changed the title -- should close named parameter lists -- should close named arg. lists Nov 2, 2023
@xparq xparq closed this as completed in dca8e5e Nov 7, 2023
@xparq xparq unpinned this issue Nov 7, 2023
xparq added a commit that referenced this issue Nov 7, 2023
@xparq
Close #13: -- should stop parsing named args
b58620e 
...unless this is disabled with the `DashDashIsPositional` flag

+ Various code quality improvements (e.g. eliminated the old private
  state variables, readability renames, tentative new flag values etc.)
+ Added a busybox.exe to the test runner, because the PATH separator
  mismatch between Git sh and BusyBox sh made the GitHub test fail :-/
xparq added a commit that referenced this issue Nov 8, 2023
@xparq
Close #13: -- should stop parsing named args
fd07273 
...unless this is disabled with the `DashDashIsPositional` flag

+ Various code quality improvements (e.g. eliminated the old private
  state variables, readability renames, tentative new flag values etc.)
+ Added a busybox.exe to the test runner, because the PATH separator
  mismatch between Git sh and BusyBox sh made the GitHub test fail :-/
+ Oops, and also added . to the test PATH, so the new prefixless RUN cmds
  can actually be found. (It worked in my local config anyway though! :-o )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xparq