Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance and Integration tests with CI #49

Open
CJ-Wright opened this issue Oct 4, 2017 · 3 comments
Open

Acceptance and Integration tests with CI #49

CJ-Wright opened this issue Oct 4, 2017 · 3 comments

Comments

@CJ-Wright
Copy link
Member

We should have a simulated beamline repo who's job it is to run the xpdAcq/xpdAn integration and acceptance tests on a CI. This will a) give us a place to put all the interesting breaking use cases we run into and b) allow us to run tests that normally require our physical presence at the beamline on a CI, and c) means that our acceptance tests at the beamline are more likely to be fully featured and successful.

Expected Behavior

Use cases get written up as tests.
Acceptance tests get written up as tests.
CI runs tests.
We fix breakages.

Current Behavior

None of this happens

Possible Solution

One interesting part of this is that we can have all the inputs (motors, detectors, etc.) to the tests as pytest features. When it comes time to run the acceptance tests at the beamline we just import all the tests and then hand them all the previously simulated things as the real hardware and run them.

Context

Integration tests may save us from a world of pain.
Acceptance tests were requested by the BLS

Priority

High

@CJ-Wright CJ-Wright self-assigned this Oct 5, 2017
@CJ-Wright CJ-Wright added the Epic label Oct 5, 2017
@CJ-Wright CJ-Wright added this to the 2018 Cycle 1 milestone Oct 5, 2017
@sbillinge
Copy link
Member

sbillinge commented Oct 8, 2017 via email

@sbillinge sbillinge modified the milestones: 2018 Cycle 1, 2018 Cycle 2 Oct 10, 2017
@sbillinge
Copy link
Member

Moving this to cycle 2 as cycle 1 release is getting loaded up now and this is important but lower priority (not mission critical)

@CJ-Wright CJ-Wright modified the milestones: 2018 Cycle 2, 2018 Cycle 1 Oct 25, 2017
@chiahaoliu chiahaoliu modified the milestones: 2018 Cycle 1, 2018 Cycle 2 Feb 26, 2018
@CJ-Wright CJ-Wright removed this from the 2018 Cycle 2 milestone Aug 7, 2018
@CJ-Wright
Copy link
Member Author

It would be good to have acceptance tests first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants