-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement timezone support + Restore default UTC interpretation #10
base: master
Are you sure you want to change the base?
Conversation
Thank you @chdanielmueller. This is similar to what I wrote yesterday. We have to do two more things
|
To point 1: To point 2: |
|
@xpepermint Any timeline on this? |
Hey @chdanielmueller. Sorry, no timeline. My todo is filled with other tasks right now :(. |
@xpepermint Any news? |
Sorry, you'll have to use a fork until this is merged. |
Before v1.5.0 the library did always use UTC time to parse the cron syntax.
The change to
cron-parser
did alter this behavior.It now uses the local timezone as default.
My proposal is to revert to the previous behavior as default to not create any breaking changes.
Another proposal is to allow the change of the
tz
of thecron-parser
using a new option inmongodb-cron
.This would allow the user to use any timezone he desires for the parsing of the intervals.
The sleepUntil field is still saved as a UTC timestamp in any case.
closes #8