Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional 'comments' feed item #2

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Add optional 'comments' feed item #2

merged 2 commits into from
Feb 20, 2018

Conversation

axispx
Copy link
Contributor

@axispx axispx commented Feb 14, 2018

No description provided.

@xqwzts
Copy link
Owner

xqwzts commented Feb 17, 2018

@anarchyrucks Thanks for contributing!

I took a look at the RSS 2.0 spec and it seems comments is only expected to be included under individual items [feed_item.dart] and not per-feed [feed.dart]. You've implemented it under both in this PR, is that a scenario that you came across?

If you aren't coming across Feed-level comments then I'd prefer to remove that, and only add the FeedItem comments field.

Otherwise this looks great and is only missing tests: I've been placing all these optional field tests under the 'Parses a Feed with all possible fields' test.

Thanks again!

@axispx
Copy link
Contributor Author

axispx commented Feb 18, 2018

@xqwzts Thanks for the review.

The comments element is indeed not required per feed. That was a mistake on my part.

I also added test for the comments element for each individual item.

@xqwzts xqwzts merged commit 86458b5 into xqwzts:master Feb 20, 2018
@xqwzts
Copy link
Owner

xqwzts commented Feb 20, 2018

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants