Update for dart 2 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xqwzts
requested changes
Sep 7, 2018
There was a problem hiding this comment.
@solid-software Thanks for the contribution!
This is great, but with the jump to version 2 of the dart sdk being a breaking change, we should also drop support for dart 1 at this point by raising the minimum compatible version too.
Would be good to merge once that's in.
pubspec.yaml
Outdated
| @@ -6,7 +6,7 @@ authors: | |||
| homepage: https://github.com/xqwzts/feedparser | |||
|
|
|||
| environment: | |||
| sdk: '>=1.21.0 <2.0.0' | |||
| sdk: '>=1.21.0 <3.0.0' | |||
There was a problem hiding this comment.
We should also raise the minimum sdk version we're compatible with, as moving to 2.0 is a breaking change, and we can now drop support for older sdks.
sdk: ">=2.0.0-dev.58.0 <3.0.0" should be fine.
|
Done |
marianoarga
approved these changes
Sep 10, 2018
|
Please merge this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.