Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoRa_E32.h for stm32 rogerclerk library #48

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Update LoRa_E32.h for stm32 rogerclerk library #48

merged 1 commit into from
Sep 19, 2022

Conversation

satyanvesi
Copy link
Contributor

This is a little fix if you are using stm32 https://github.com/rogerclarkmelbourne/Arduino_STM32 library.

@xreef
Copy link
Owner

xreef commented Sep 19, 2022

Hi @satyanvesi,
for that board, manager isn't sufficient
!defined(ARDUINO_ARCH_STM32)
if we add
!defined(__STM32F1__)
we must add add
!defined(__STM32F4__)
and similar?

Thanks Renzo

@satyanvesi
Copy link
Contributor Author

but i tested without !defined(__STM32F1__) it didnt compile the sketch and yes we add !defined(__STM32F4__) and similar.

@xreef xreef merged commit 970e4f5 into xreef:master Sep 19, 2022
xreef added a commit that referenced this pull request Sep 19, 2022
xreef added a commit that referenced this pull request Sep 19, 2022
xreef added a commit to xreef/EByte_LoRa_E22_Series_Library that referenced this pull request Sep 19, 2022
xreef added a commit to xreef/EByte_LoRa_E220_Series_Library that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants