Antd v5 compatibility #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antd v5 compatibility
Codecov ReportBase: 84.75% // Head: 84.75% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 12 12
Lines 492 492
Branches 197 197
=======================================
Hits 417 417
Misses 12 12
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xrutayisire
reviewed
Nov 21, 2022
src/Cron.tsx
Outdated
| @@ -1,5 +1,5 @@ | |||
| import React, { useState, useCallback, useEffect, useRef, useMemo } from 'react' | |||
| import Button from 'antd/lib/button' | |||
| import { Button } from 'antd' | |||
There was a problem hiding this comment.
There is a non-breaking space in this code:
There was a problem hiding this comment.
Should be fixed, at least its not showing any error on my side.
chillyistkult
force-pushed
the
master
branch
from
46bb9d5
to
0ff803f
Compare
|
Thanks! I will create a new release soon with this fix when I'm done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
💡 Background and solution
Antd v5 got released dropping antd/es and antd/lib packages (which should have never been used anyway). This PR is fixing imports.
☑️ Self Check before Merge