Provide control over select props for each field type #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have recently run into a problem where the onMouseDown event handler in antd/lib/select component is causing a modal (where the Cron component is rendered) to close. It has been found that this is due to the event bubbling. To solve this we can either: 1. Explicitly set the onMouseDown to not propagate the event, or 2. Provide more granular control over each select component that can be rendered by the Cron component This PR addresses Option 2. The Cron component can take a `customSelectProps` prop which is an object which has optional `SelectProps` definitions for each field type. These are then spread into each respective field component in `Cron.tsx`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 84.75% 84.78% +0.03%
==========================================
Files 12 12
Lines 492 493 +1
Branches 197 198 +1
==========================================
+ Hits 417 418 +1
Misses 12 12
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hello, thanks for the MR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
We have recently run into a problem where the onMouseDown event handler in antd/lib/select component is causing a modal (where the Cron component is rendered) to close. It has been found that this is due to the event bubbling. To solve this we can either:
This PR addresses Option 2.
The Cron component can take a
customSelectPropsprop which is an object which has optionalSelectPropsdefinitions for each field type. These are then spread into each respective field component inCron.tsx.☑️ Self Check before Merge