Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate runtime deps #56

Closed
bbatsov opened this issue Jun 18, 2015 · 4 comments
Closed

Isolate runtime deps #56

bbatsov opened this issue Jun 18, 2015 · 4 comments
Assignees

Comments

@bbatsov
Copy link

bbatsov commented Jun 18, 2015

lein-ancient's dependencies might interfere with a project's own dependencies. It'd best to isolate its runtime dependencies using a tool like https://github.com/benedekfazekas/mranderson or https://github.com/jafingerhut/dolly

@xsc
Copy link
Owner

xsc commented Jun 18, 2015

Those look interesting. I'll have a look.
Thanks!

@xsc xsc self-assigned this Jun 18, 2015
@bbatsov
Copy link
Author

bbatsov commented Jun 18, 2015

Btw, here's the PR that got this integrated into cider-nrepl clojure-emacs/cider-nrepl#183

Might be useful as well.

@aiba
Copy link

aiba commented Mar 26, 2016

I think I'm running into this issue.

With :pedantic? :abort and plugins that include both [lein-ancient "0.6.9-SNAPSHOT"] and [lein-figwheel "0.5.2"], I get the error:

Possibly confusing dependencies found:
[lein-ancient "0.6.9-SNAPSHOT"] -> [org.clojure/tools.reader "0.10.0"]
 overrides
[lein-figwheel "0.5.2"] -> [figwheel "0.5.2"] -> [org.clojure/clojurescript "1.7.228" :exclusions [org.apache.ant/ant]] -> [org.clojure/tools.reader "1.0.0-alpha1"]
 and
[lein-figwheel "0.5.2"] -> [figwheel-sidecar "0.5.2"] -> [org.clojure/clojurescript "1.7.228" :exclusions [org.apache.ant/ant]] -> [org.clojure/tools.reader "1.0.0-alpha1"]

Consider using these exclusions:
[lein-figwheel "0.5.2" :exclusions [org.clojure/tools.reader]]
[lein-figwheel "0.5.2" :exclusions [org.clojure/tools.reader]]

My workaround is to put into ~/.lein/profiles.clj:

:ancient {:pedantic? true ;; warnings but don't abort
          :plugins [[lein-ancient "0.6.9-SNAPSHOT"]]}

And run ancient with lein with-profile +ancient ancient.

This also has the side benefit of not loading lein-ancient's deps when doing normal development/production lein tasks.

xsc pushed a commit that referenced this issue Apr 2, 2016
- Fixes #72 and closes #56.
- Some dependencies didn't play so well with mranderson:
  - potemkin only works without class repackaging,
  - mranderson sometimes prefixes 'clojure.lang.*' imports without
    actually having repackaged the classes.
xsc pushed a commit that referenced this issue Apr 2, 2016
- Fixes #72 and closes #56.
- Some dependencies didn't play so well with mranderson:
  - potemkin only works without class repackaging,
  - mranderson sometimes prefixes 'clojure.lang.*' imports without
    actually having repackaged the classes.
@xsc xsc closed this as completed in 03cd306 Apr 2, 2016
@xsc
Copy link
Owner

xsc commented Apr 2, 2016

Dependency isolation has landed in 0.6.10.

Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants