Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEP-0347 references an external resource #62

Closed
linuxwolf opened this issue Aug 24, 2015 · 5 comments
Closed

XEP-0347 references an external resource #62

linuxwolf opened this issue Aug 24, 2015 · 5 comments
Assignees

Comments

@linuxwolf
Copy link
Contributor

XEP-0347 references an image hosted outside of xmpp.org.

It is undesirable for XEPs to include references outside of the XEP change control process. Some allowances might be necessary, but such exceptional references also must be clearly marked as non-normative and outside the change control process.

@linuxwolf linuxwolf self-assigned this Sep 22, 2015
@intosi
Copy link
Contributor

intosi commented Mar 18, 2016

I would say it's not only undesirable, it's outright wrong. The images are part of the spec.

@PeterWaher
Copy link
Contributor

Are you referring to the reference to the Google chart API to generate a QR-code?

@winfried
Copy link
Contributor

Correct

On March 18, 2016 6:16:07 PM CET, Peter Waher notifications@github.com wrote:

Are you referring to the reference to the Google chart API to generate
a QR-code?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#62 (comment)

Normally there is some text here bragging about the new mobile phone and excusing for the brevity. That is insane. If this phone was really that great, I would have sent a decent mail.

@PeterWaher
Copy link
Contributor

Ok. Is it the textual Google API reference that is the problem (in the example), or is it the image tag, linking to the API to generate a QR code? (It's only an example of how a QR code can be created). If it's the latter, I can replace the image with an embedded image using the data URI scheme.

@SamWhited
Copy link
Member

SamWhited commented Jul 15, 2016

@PeterWaher This is mostly the image itself (there should be no external resources loaded from any XEPs; what if Google sunsets the charts API? The XEP would be broken, and we don't want that), but I'd say that it's preferable not to make recommendations in general about libraries or software to use. That's an implementation detail, so having "you can use Google Charts to make QR codes" is unnecessary.

@SamWhited SamWhited assigned SamWhited and unassigned linuxwolf Aug 20, 2016
SamWhited added a commit to SamWhited/xeps that referenced this issue Aug 20, 2016
SamWhited added a commit to SamWhited/xeps that referenced this issue Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants