Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add license for bibliographic data" #1221

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

horazont
Copy link
Contributor

Reverts #1220

It breaks the docker build and I don't have the time to investigate it right now.

@horazont
Copy link
Contributor Author

FTR:

docker build . --build-arg NCORES=9  -t registry.gitlab.com/xsf/xeps/packed:main-latest
Sending build context to Docker daemon  58.08MB
Step 1/16 : FROM xmppxsf/xeps-base:latest as build
 ---> ebc49b11c829
Step 2/16 : ARG NCORES=1
 ---> Using cache
 ---> 27d416a46583
Step 3/16 : ARG TARGETS="html inbox-html inbox-xml pdf xeplist refs xml"
 ---> Using cache
 ---> 8cad48ff5bf2
Step 4/16 : COPY *.xml xep.* *.css *.xsl *.js *.xsl Makefile /src/
 ---> Using cache
 ---> dee5e2622d3f
Step 5/16 : COPY resources/*.pdf /src/resources/
 ---> 608d1a5f9490
Step 6/16 : COPY tools/*.py /src/tools/
 ---> e8570764526d
Step 7/16 : COPY inbox/*.xml inbox/*.ent inbox/*.dtd /src/inbox/
 ---> ed2b973c0bac
Step 8/16 : COPY texml-xsl/*.xsl /src/texml-xsl/
 ---> 90a6b28262e7
Step 9/16 : WORKDIR /src
 ---> Running in b0ed5b013cd4
Removing intermediate container b0ed5b013cd4
 ---> 22e2a6da09a7
Step 10/16 : RUN OUTDIR=/var/www/html/extensions/ make -j$NCORES $TARGETS
 ---> Running in a02f99a2f4c0
make: *** No rule to make target 'refs-LICENSE', needed by '/var/www/html/extensions//refs/LICENSE'.  Stop.
make: *** Waiting for unfinished jobs....
The command '/bin/sh -c OUTDIR=/var/www/html/extensions/ make -j$NCORES $TARGETS' returned a non-zero code: 2

@horazont
Copy link
Contributor Author

cc @Flowdalic

@horazont horazont merged commit 8d1f8e0 into master Oct 12, 2022
@Flowdalic
Copy link
Contributor

Flowdalic commented Oct 12, 2022

I've no idea how to obtain the used Dockerfile, but I suspect that it is because

COPY .xml xep. *.css *.xsl *.js *.xsl Makefile /src/

which does not copy refs-LICENSE and in general it seems to be a bad idea to copy files from the repo over, as it is fragile (as demonstrated by this issue).

@horazont
Copy link
Contributor Author

I've no idea how to obtain the used Dockerfile

Try this: https://github.com/xsf/xeps/blob/master/Dockerfile

Flowdalic added a commit to Flowdalic/xeps-xsf that referenced this pull request Dec 11, 2023
We were asked [1] to state that the XEP bibliographic data is openly
available and free of charge if we want it to be consumed by third
parties.

This weas previously merged as 7477388 ("Add license for
bibliographic data"), but unfortunately later reverted in
59b2a5c ("Revert "Add license for bibliographic data"",
xsf#1221). However, the fix for the
broken docker build is trivial: simply also copy refs-LICENSE into the
container. This commit does that.

Fixes xsf#1219.

1: ietf-tools/bibxml-service#302 (comment)
Flowdalic added a commit to Flowdalic/xeps-xsf that referenced this pull request Dec 11, 2023
We were asked [1] to state that the XEP bibliographic data is openly
available and free of charge if we want it to be consumed by third
parties.

This weas previously merged as 7477388 ("Add license for
bibliographic data"), but unfortunately later reverted in
59b2a5c ("Revert "Add license for bibliographic data"",
xsf#1221). However, the fix for the
broken docker build is trivial: simply also copy refs-LICENSE into the
container. This commit does that.

Fixes xsf#1219.

1: ietf-tools/bibxml-service#302 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants