Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross-site frame counting real world example section with a new patched bug on GitHub #152

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

mr-medi
Copy link
Contributor

@mr-medi mr-medi commented Aug 27, 2023

Hi,

I've made an update to the frame-counting.md file, adding a new example that discusses a blog post I recently published. The example illustrates how cross-site frame counting can potentially expose private repositories on GitHub. I'm excited about the opportunity to contribute to your repository, especially since I've gained valuable insights from it.

Thank you for your dedicated work!

@NDevTK
Copy link
Contributor

NDevTK commented Aug 27, 2023

is exposing private repositories on GitHub limited to checking if a file exists not the file contents?
they did not add COOP :(

@mr-medi
Copy link
Contributor Author

mr-medi commented Aug 27, 2023

Hi @NDevTK,

Yeah, in this specific scenario, it's only possible to expose the name of private repositories and the names of the files associated with them. Using cross-site frame counting, it's not possible to expose the full content of the files or any specific section of the content in this context.

Thank you for your reply :)

@terjanq terjanq self-requested a review September 8, 2023 10:38
@terjanq
Copy link
Member

terjanq commented Sep 8, 2023

Thanks for the contribution! Even though it's a small change to the wiki, feel free to add yourself to contributors https://xsleaks.dev/docs/contributions/

@mr-medi
Copy link
Contributor Author

mr-medi commented Sep 15, 2023

Thank you very much, @terjanq, for accepting my pull request. I will add a new commit that includes me in the list of contributors, and I look forward to continuing to contribute in the future.

I've noticed that there seems to be an error <failed to extract shortcode: shortcode "hint" must be closed or self-closed> when rendering the file /contributions/_index.md:49:1. This error seems to occurs due to a tag in Hugo during the checks that run when a PR is being merged and it failed to merge the changes. I've read the code, and all the hints tags appear to be correctly declared.

Do you have any insights on what might be causing this issue?

@terjanq terjanq merged commit 62b0ae8 into xsleaks:master Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants