From pull request #129 discussion: suppress warning message and clean up temporary files #131
Conversation
vincentml
changed the title
|
This looks good to me, I'm the process of writing some tests for this pull request, I'll keep you posted. |
There was a problem hiding this comment.
This looks good to me. I tested it by running the shell script under Linux and the batch script under Windows and I confirm that the Schematron warnings are not showing up anymore.
In branch test/131 I added two tests, one for the shell script and one for the batch script. These tests make sure that the warnings do not appear: they check the position of the output "Compiling the Schematron tests...", if there are warning the position of this output is not at the given lines. Branch test/131 also contains your changes.
@vincentml: would you be able to integrate these tests in your pull request? Alternatively you can close this pull request and initiate a new one from branch test/131 - if you agree with the logic of my tests, of course.
* add tests for removal of Schematron warnings xspec#131 * create directory for schematron at setup/teardown stages
|
@cirulls , I've merged the tests that you added into this pull request. I also added a test to show that the cleanup removes temporary files for the batch script, however I've not been able to write a similar working test for the shell script. |
|
I've added an equivalent test for the shell script to check that temporary files are removed. |
…ning an XSLT 10 stylesheet with an XSLT 20 processor" during Schematron compilation and clean up temporary files.
* add tests for removal of Schematron warnings xspec#131 * create directory for schematron at setup/teardown stages
* 'master' of git://github.com/xspec/xspec: Allow Schematron XSLTs to be provided externally (xspec#133) From pull request xspec#129 discussion: suppress warning message and clean up temporary files (xspec#131) add XProc harness for BaseX standalone (review xspec#103) (xspec#136) Add documentation for Schematron support (xspec#129) add Schematron support (xspec#105) add checks for saxon script + test (xspec#124) Run tests with XML Calabash 1.1.16-97 (xspec#123) Escape apostrophe in URI (xspec#119) xspec.bat (Windows) fails when path contains parentheses
* 'master' of git://github.com/xspec/xspec: Add TODO comments for focus/pending tests in #4 (#61) End-to-end test for XSpec itself (#81) Allow Schematron XSLTs to be provided externally (xspec#133) From pull request xspec#129 discussion: suppress warning message and clean up temporary files (xspec#131) add XProc harness for BaseX standalone (review xspec#103) (xspec#136) Add documentation for Schematron support (xspec#129) add Schematron support (xspec#105) add checks for saxon script + test (xspec#124) Run tests with XML Calabash 1.1.16-97 (xspec#123) Escape apostrophe in URI (xspec#119) xspec.bat (Windows) fails when path contains parentheses Do not copy unused namespaces from format utils to output (xspec#91) Stop using functx namespace (xspec#104)
As discussed in pull request #129: suppress warning message "Running an XSLT 10 stylesheet with an XSLT 20 processor" during Schematron compilation and clean up temporary files.