Schematron Ant: Do not set bogus phase parameter when phase is undefined #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another variance between the Ant script and |
|
Right. That too was missing from the original PR. |
|
This change has been integrated in oxygen 20. So I proposed this for v.1.1.0. |
|
Two months have passed since oxygen was shipped with this change. |
|
@cirulls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
If the user sets no
xspec.phaseproperty and the .xspec file defines no phase in Schematron testing,build.xmlsets a bogus phase parameter at STEP 3.So the user has to set
xspec.phaseexplicitly, when testingdemo-03.xspec. Though that's how the original PR #160 was designed, the design is not aligned withxspec.bat/shwhich works more friendly.With this PR, the user no longer has to set
xspec.phasewhen testingdemo-03.xspecand the like.