-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ANT_VERSION in xspec-bat.cmd #244
Conversation
@cirulls |
…RSION # Conflicts: # test/xspec-bat.cmd
…RSION # Conflicts: # test/xspec-bat.cmd
…RSION # Conflicts: # appveyor.yml
…RSION # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…RSION # Conflicts: # test/xspec.bats
I executed However, I'd like to highlight an inconsistency between Conversely, the ant tests in These scenarios occur when the test suite is executed locally. In fact, on Travis and AppVeyor ant is always installed first and, if the installation is not successful, there is an error code as we saw recently. I'm not too fuzzy about which way we lean on (i.e. adding the check in @AirQuick, what's your opinion on this? |
Right. They're inconsistent. So this pull request (#244) should be considered as a transitory measure to ease testing locally until #289. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying and for fixing the inconsistency in another pull request. I'm merging this into master
.
To prevent spurious test failures,
xspec-bat.cmd
(a test script for Windows) skips Ant tests when theANT_VERSION
environment variable is not defined.You have to set the variable manually if you want to run Ant test on your local machine.
This pull request sets a pseudo
ANT_VERSION
inxspec-bat.cmd
, ifant
is available inPATH
. Now you don't have to set the variable manually.No code change in XSpec core.
This pull request derives from #243. So needs to be handled after that.