Consolidate path tests #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b97ec5c.
So I think this pull request can be merged (after #257) safely without reviewing details, or I'd like to merge this by myself in a few days. |
…e-path-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…e-path-tests # Conflicts: # test/xspec-bat.cmd
…e-path-tests # Conflicts: # appveyor.yml
…e-path-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…e-path-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…e-path-tests # Conflicts: # test/xspec-bat.cmd
…e-path-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…e-path-tests # Conflicts: # test/xspec-bat.cmd
…e-path-tests # Conflicts: # test/xspec.bats
…e-path-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
…e-path-tests # Conflicts: # test/xspec-bat.cmd # test/xspec.bats
cirulls
approved these changes
Oct 7, 2018
There was a problem hiding this comment.
This looks good to me and it is in line with the pull requests previously merged. It is useful to consolidate these tests in order to speed up the execution of the test suite on Travis and AppVeyor (we now have many more tests to run and the test suite has increased the total execution time, especially on AppVeyor).
I reviewed this pull request by inspecting the code, making sure that both tests are covered in the path, and running the test suite locally on Linux and Windows.
I'm merging this into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xspec.bats(a test script for *nix) andxspec-bat.cmd(a test script for Windows) have 2 tests for path related issues (#84 and #119).Though they need to check the same things, each of them runs XSpec individually (with a different path).
This pull request consolidates them and runs XSpec just once (with a combined path).
No code change in XSpec core.
This pull request derives from #257. So needs to be handled after that.