Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test/end-to-end/cases/ in schema validation test #305

Merged
merged 132 commits into from
Jan 16, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Aug 26, 2018

This pull request derives from #304. So needs to be handled after that.


#304 made all the *.xspec files in test/end-to-end/cases/ valid. So this pull request includes them in the schema validation test.

A test failure is demonstrated on Travis and AppVeyor using a temporary broken commit (be7c92f).

…a-e2e-files

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…c-rule

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…c-rule

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…185_cumulative

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…a-e2e-files

# Conflicts:
#	.travis.yml
#	appveyor.yml
#	bin/xspec.bat
#	test/xspec-bat.cmd
#	test/xspec.bats
…185_cumulative

# Conflicts:
#	test/saxon-custom-options/config.xml
#	test/saxon-custom-options/test.xspec
#	test/xspec-bat.cmd
#	test/xspec.bats
…185_cumulative

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…c-rule

# Conflicts:
#	build.xml
#	test/saxon-custom-options/config.xml
#	test/saxon-custom-options/test.xspec
#	test/xspec-bat.cmd
#	test/xspec.bats
…a-e2e-files

# Conflicts:
#	build.xml
#	test/saxon-custom-options/config.xml
#	test/saxon-custom-options/test.xspec
#	test/xspec-bat.cmd
#	test/xspec.bats
…k/xspec into valid-xspec-rule

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…c-rule

# Conflicts:
#	build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
…a-e2e-files

# Conflicts:
#	build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
…c-rule

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…a-e2e-files

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…c-rule

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
@AirQuick AirQuick added this to the v1.2.0 milestone Dec 24, 2018
…a-e2e-files

# Conflicts:
#	test/run-bats.cmd
#	test/run-bats.sh
#	test/win-bats/collection.xml
#	test/xspec.bats
…a-e2e-files

# Conflicts:
#	bin/xspec.bat
#	test/win-bats/collection.xml
#	test/xspec.bats
@AirQuick
Copy link
Member Author

AirQuick commented Dec 30, 2018

I'll merge this as soon as #304 gets merged and the master turns green, because

  • The change is trivial (ac02030)
  • No code change in XSpec core
  • Test failure is demonstrated on Travis and AppVeyor
  • The test scripts are working on Travis and AppVeyor
  • The test in question will be replaced anyway (Test more .xspec files and schema #363)

@AirQuick AirQuick merged commit 758fdad into xspec:master Jan 16, 2019
@AirQuick AirQuick deleted the test_schema-e2e-files branch January 16, 2019 14:50
@AirQuick
Copy link
Member Author

@cirulls
Merged this PR whose title says it all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant