Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source document at runtime (XSLT) #437

Merged
merged 733 commits into from
Apr 23, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Nov 17, 2018

This pull request derives from #436. So needs to be handled after that.


Fixes #423

This pull request removes the source document from XSLT.

Commits

Further work

Document in Wiki that the global variables/parameters in the tested XSLT are evaluated with no context.

…selection_xquery

# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
…308_xquery

# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
…-423_xproc

# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
…-423_xquery

# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
…doc_xquery

# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
…doc_xslt

# Conflicts:
#	build.xml
#	test/ant/README.md
#	test/ant/build.xml
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/_serializer.xsl
#	test/end-to-end/processor/base/_deserializer.xsl
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/base/_serializer.xsl
#	test/end-to-end/processor/base/_util.xsl
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/processor/html/_normalizer.xsl
#	test/end-to-end/processor/html/_serializer.xsl
#	test/end-to-end/processor/junit/_deserializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/junit/_serializer.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/run-xspec-tests-ant.cmd
#	test/run-xspec-tests-ant.sh
#	test/xspec-bat.cmd
#	test/xspec.bats
…from-xquery-xml

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…talog

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…talog

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…nto rm-pkg-ns-from-xquery-xml

# Conflicts:
#	bin/xspec.bat
#	build.xml
#	test/ant/common/generate-build-worker.xsl
#	test/end-to-end/generate-expected.cmd
#	test/end-to-end/generate-expected.sh
#	test/end-to-end/processor/base/compare.xsl
#	test/end-to-end/processor/base/normalize.xsl
#	test/end-to-end/run-e2e-tests.cmd
#	test/end-to-end/run-e2e-tests.sh
#	test/xspec.bats
…result-naming-collision_e2e

# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
…b.com/AirQuick/xspec into fix_issue-355-357-358-360-361

# Conflicts:
#	test/end-to-end/processor/base/_normalizer.xsl
# Conflicts:
#	test/xspec-bat.cmd
#	test/xspec.bats
# Conflicts:
#	bin/xspec.bat
#	bin/xspec.sh
#	java/com/jenitennison/xslt/tests/XSLTCoverageTraceListener.class
#	java/com/jenitennison/xslt/tests/XSLTCoverageTraceListener.java
#	src/common/xspec-utils.xsl
#	src/compiler/generate-common-tests.xsl
#	src/compiler/generate-query-tests.xsl
#	src/compiler/generate-tests-utils.xsl
#	src/compiler/generate-xspec-tests.xsl
#	src/reporter/format-xspec-report.xsl
#	src/reporter/junit-report.xsl
#	src/schematron/schut-to-xspec.xsl
#	test/end-to-end/cases/expected/query/xspec-focus-1-result.html
#	test/end-to-end/cases/expected/query/xspec-function-result.html
#	test/end-to-end/cases/expected/query/xspec-import-result.html
#	test/end-to-end/cases/expected/query/xspec-imported-result.html
#	test/end-to-end/cases/expected/query/xspec-pending-result.html
#	test/end-to-end/cases/expected/schematron/schematron-01-result.xml
#	test/end-to-end/cases/expected/stylesheet/coverage-tutorial-coverage.html
#	test/end-to-end/cases/expected/stylesheet/coverage-tutorial-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-153-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-177-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-177-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-177-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-214-coverage.html
#	test/end-to-end/cases/expected/stylesheet/xspec-214-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-214-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-23_2-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-23_2-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-23_2-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-50-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-55-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-67-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-67-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-ambiguous-expect-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-focus-1-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-function-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-import-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-imported-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-pending-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-rule-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-three-dots-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-xslt2-result.xml
#	test/end-to-end/processor/base/_normalizer.xsl
#	test/end-to-end/processor/coverage/_serializer.xsl
#	test/end-to-end/processor/junit/_normalizer.xsl
#	test/end-to-end/processor/xml/_normalizer.xsl
#	test/schematron-param-001.xspec
#	test/win-bats/collection.xml
#	test/xspec-space_stylesheet.xspec
#	test/xspec-utils.xspec
#	test/xspec.bats
…test-params

# Conflicts:
#	src/compiler/generate-query-utils.xql
#	src/compiler/generate-tests-utils.xsl
#	test/end-to-end/cases/expected/query/xspec-346-result.html
#	test/end-to-end/cases/expected/query/xspec-346-result.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-346-junit.xml
#	test/end-to-end/cases/expected/stylesheet/xspec-346-result.html
#	test/end-to-end/cases/expected/stylesheet/xspec-346-result.xml
#	test/end-to-end/cases/xspec-346.xspec
…doc_xslt

# Conflicts:
#	bin/xspec.bat
#	bin/xspec.sh
#	test/win-bats/collection.xml
#	test/xspec.bats
@AirQuick AirQuick merged commit bfb82d8 into xspec:master Apr 23, 2019
@AirQuick AirQuick deleted the rm-source-doc_xslt branch April 23, 2019 12:56
@AirQuick
Copy link
Member Author

AirQuick commented Apr 23, 2019

@cirulls
Merged this bug fix.

This change may need to be mentioned in the release note. Some people may be surprised when they find their XSpec crashing on the next release. (The fact is that such stylesheets were running on XSpec just luckily.)

Further work

Document in Wiki that the global variables/parameters in the tested XSLT are evaluated with no context.

Done.

@cirulls
Copy link
Member

cirulls commented Apr 24, 2019

@AirQuick: I added this to the draft releases notes under bug fixes and documentation and added a line in the intro text to remind us about an explicit mention of this bug fix when the next release is issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source document at runtime should be removed
2 participants