Accept x:description without XSpec namespace prefix #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #572
This pull request
XsPeC:
) when the test author does not provide a prefix to the XSpec namespace (http://www.jenitennison.com/xslt/xspec
) inx:description
.Tests
As far as I know, most test authors provide a prefix (
x:
in most cases) to the XSpec namespace. SchXslt is the only use case I've ever found. So I didn't write the test for this pull request extensively.xspec-no-prefix.xspec
tests both XQuery and XSLT.xspec-no-prefix_schematron.xspec
) and XSLT-only (xspec-no-prefix_stylesheet.xspec
), I just copied some of the existing test files and removed thex:
prefix.Note for the test result
I found weird behaviors in
xspec-no-prefix_stylesheet.xspec
with some Saxon versions:9.7.0.21-EE
test/xspec/xspec-no-prefix_stylesheet-result.xml
) omitsxmlns=""
from elements inx:result
andx:expect
. (not expected)9.7.0.21-HE, 9.8.0.12-EE/HE, 9.8.0.14-EE/HE
xmlns=""
from elements inx:result
andx:expect
. (not expected)9.8.0.15-EE/HE, 9.9.1.4-EE/HE
xmlns=""
. (as expected)Because the latest Saxon versions are working as expected, I haven't investigated the problem further.
Probably it's related to Saxon bug 3889 which was fixed on 9.9.0.1 and 9.8.0.15.