Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for Saxon 9.7 or less #625

Merged
merged 15 commits into from Sep 19, 2019

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Sep 10, 2019

See #596. This pull request prints a deprecation warning message at compile time if Saxon version is 9.7 or less.

On 9.7:

F:\xspec>bin\xspec.bat tutorial\escape-for-regex.xspec
Saxon script not found, invoking JVM directly instead.

Creating Test Stylesheet...
WARNING: Saxon version 9.7 or less is deprecated. XSpec will stop supporting it in the near future.

Running Tests...
Testing with SAXON HE 9.7.0.21
...

On 9.8 or later:

F:\xspec>bin\xspec.bat tutorial\escape-for-regex.xspec
Saxon script not found, invoking JVM directly instead.

Creating Test Stylesheet...


Running Tests...
Testing with SAXON HE 9.8.0.12
...

Commits

@AirQuick AirQuick added this to the v1.5.0 milestone Sep 10, 2019
Copy link
Member

@cirulls cirulls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I reviewed it by running xspec.sh with Saxon 9.7.0.20 and 9.9.1.5 on my machine and it behaved as you described. I also checked that Travis is now running a matrix with 4 Saxon configuration . Feel free to merge it into master.

@galtm
Copy link
Collaborator

galtm commented Sep 16, 2019

@AirQuick : I took a quick look at the code, and I should be able to do a more substantive code review by the end of this week. If you want to merge this in, based on the review by @cirulls , I have no problem with that.

@AirQuick
Copy link
Member Author

Thanks @galtm for the update. No haste for this pull request. I'll just wait for your review.

@AirQuick
Copy link
Member Author

Merged the master into this branch and added Saxon 9.7 to azure-pipelines.yml: Azure

Copy link
Collaborator

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I like that the code has many clear comments.

FYI: For the ant-related files, I can see the gist of what you're doing, but I'm not familiar enough to be able to spot a bug, if there is any.

I left one related comment at 23fc4a8#r35154819

Copy link
Collaborator

@galtm galtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of x:extract-version looks good and defensive.

@AirQuick
Copy link
Member Author

Thanks a lot @galtm!

I'm merging this.

@AirQuick AirQuick merged commit 1c198b4 into xspec:master Sep 19, 2019
@AirQuick AirQuick deleted the deprecate-saxon-9-7 branch September 19, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants