New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warning for Saxon 9.7 or less #625
Conversation
(cherry picked from commit 7c68d53)
…saxon-9-7 # Conflicts: # test/ant/worker/generate.xsl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I reviewed it by running xspec.sh
with Saxon 9.7.0.20 and 9.9.1.5 on my machine and it behaved as you described. I also checked that Travis is now running a matrix with 4 Saxon configuration . Feel free to merge it into master
.
…saxon-9-7 # Conflicts: # .travis.yml # appveyor.yml
Thanks @galtm for the update. No haste for this pull request. I'll just wait for your review. |
Merged the master into this branch and added Saxon 9.7 to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I like that the code has many clear comments.
FYI: For the ant-related files, I can see the gist of what you're doing, but I'm not familiar enough to be able to spot a bug, if there is any.
I left one related comment at 23fc4a8#r35154819
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of x:extract-version looks good and defensive.
Thanks a lot @galtm! I'm merging this. |
See #596. This pull request prints a deprecation warning message at compile time if Saxon version is 9.7 or less.
On 9.7:
On 9.8 or later:
Commits