Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematron): fix xspec.bat handling Schematron path with space #768

Merged
merged 4 commits into from
Feb 2, 2020

Conversation

AirQuick
Copy link
Member

@AirQuick AirQuick commented Feb 1, 2020

Fixes #716

@AirQuick AirQuick added the bug label Feb 1, 2020
@AirQuick AirQuick added this to the v1.6.0 milestone Feb 1, 2020
@commit-lint
Copy link

commit-lint bot commented Feb 1, 2020

Tests

  • schematron: test CLI with space char (d9b9094)

Bug Fixes

  • schematron: fix xspec.bat handling Schematron path with space (b110b0c)

Contributors

@AirQuick

@AirQuick AirQuick marked this pull request as ready for review February 1, 2020 09:03
@AirQuick
Copy link
Member Author

AirQuick commented Feb 2, 2020

I injected an @echo on into xspec.bat and verified that the variable expansion was deferred:

C:\test>java -cp "%SAXON_CP%" net.sf.saxon.Version
SAXON-HE 9.9.1.6J from Saxonica (build 120513)

C:\test>bin\xspec.bat -s "tutorial copy\schematron\demo-01.xspec"
...
Converting Schematron into XSLT...

C:\test>call :xslt ... -s:"%SCH_URI%" ...

C:\test>java ... -s:"file:/C:/test/tutorial%20copy/schematron/demo-01.sch" ...
...
passed: 3 / pending: 0 / failed: 0 / total: 3
Report available at C:\test\tutorial copy\schematron\xspec\demo-01-result.html
Done.

Merging this.

@AirQuick AirQuick merged commit 92aa951 into xspec:master Feb 2, 2020
@AirQuick AirQuick deleted the fix_issue-716 branch February 2, 2020 13:41
magwas pushed a commit to kode-konveyor/xspec that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bin/xspec.* doesn't work with Schematron in path containing space
1 participant