Add a Particles class for purely longitudinal studies (without "minitracker") #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
6 tasks
giadarol
approved these changes
Mar 21, 2023
tests/test_overriden_particle.py
Outdated
Comment on lines
22
to
25
| t = xt.Tracker(line=l, compile=False, _context=test_context) | ||
|
|
||
| t.track(p_fixed) | ||
| t.track(p) |
There was a problem hiding this comment.
please use:
l.build_tracker(_context=test_context)
l.track(...)
xtrack/beam_elements/apertures.py
Outdated
Comment on lines
256
to
257
| self.compile_kernels(particles_class=particles_class, | ||
| only_if_needed=True) |
Comment on lines
46
to
49
| temp_poly.impact_point_and_normal(particles_class=tracker.particles_class, | ||
| x_in=na([0]), y_in=na([0]), | ||
| z_in=na([0]), x_out=na([2]), | ||
| y_out=na([2]), z_out=na([0])) |
| @@ -464,6 +466,7 @@ def characterize_aperture(tracker, i_aperture, n_theta, r_max, dr, | |||
| # Get a convex polygon that has vertices at all requested angles | |||
| r_out = 1. # m | |||
| res = temp_poly.impact_point_and_normal( | |||
| particles_class=tracker.particles_class, | |||
Signed-off-by: Szymon Łopaciuk <szymon@lopaciuk.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt xtrack to the new particles classes introduced in xsuite/xpart#73, however do not use the idea of a minitracker proposed in #312.
Replaces #312.
Checklist
Mandatory:
Optional: